On Thu, 21 Mar 2024 17:36:24 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> Do we need an occasional _Skip_ button? Yet adding such a button to throw >> `jtreg.SkippedException` will introduce a transitive dependency on the >> library which contains the `SkippedException`. > > I'm OK with either direction. To me, passing the test seems fine for cases > we'd skip, but adding a `Skip` button may seem more logical. I was OK with > this approach enough to stick with the original instructions. I'm not suggesting modifying the instructions, I'm bringing up it for a discussion. Essentially, `SkippedException` is also like passing the test, it's indistinguishable in the report. Only the log of the test run will contain the information that the test was skipped. >From this point of view, it's wiser not to introduce an additional dependency >which will affect all the manual tests. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534359360
