On Fri, 16 Aug 2024 10:11:11 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> Tejesh R has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains four additional commits >> since the last revision: >> >> - Updated review comments >> - Merge branch 'master' of https://git.openjdk.java.net/jdk into >> branch_8338041 >> - Test updates >> - Key action modified + Automatic test added > > test/jdk/javax/swing/plaf/gtk/JTableCtrlShiftRightLeftKeyTest.java line 117: > >> 115: endCellCheck) { >> 116: System.out.println("Selected Columns: "); >> 117: for (int columnAfterTabPress : selectedColumnAfterKeyPress) >> { > > I don't think it is required to print the selected column.. If at all it is > required for debugging I guess `columnAfterTabPress` should be renamed as > columns are not selected after tab press. It is required for preliminary analysis, rather than screen capturing on failure cases. I've updated the name. > test/jdk/javax/swing/plaf/gtk/JTableCtrlShiftRightLeftKeyTest.java line 120: > >> 118: System.out.println(columnAfterTabPress); >> 119: } >> 120: String key = (keySelected == KeyEvent.VK_RIGHT)? "RIGHT" : >> "LEFT"; > > "RIGHT" or "LEFT" can be passed as an argument to this method. This check can > be removed. Yes, updated. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20608#discussion_r1722833940 PR Review Comment: https://git.openjdk.org/jdk/pull/20608#discussion_r1722832733
