On Tue, 20 Aug 2024 07:26:12 GMT, Tejesh R <t...@openjdk.org> wrote: >> In JTable, keyboard navigation keys Ctrl Shift RIGHT/LEFT doesn't follow >> native actions of Linux. In native the actions are extended to end of >> selected columns cells either LEFT/RIGHT but in swing gtk look and feel the >> selection is extended to one cell to left/right. This might be taken as >> reference of Windows OS since the same is observed in Windows native. Hence >> I have update the actions for Ctrl Shift RIGHT & LEFT. >> Added automated test too. The fix is tested in CI and its fine. > > Tejesh R has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains four additional commits since > the last revision: > > - Updated review comments > - Merge branch 'master' of https://git.openjdk.java.net/jdk into > branch_8338041 > - Test updates > - Key action modified + Automatic test added
test/jdk/javax/swing/plaf/gtk/JTableCtrlShiftRightLeftKeyTest.java line 124: > 122: String failureMsg = "Test Failure. Failed to select cells > for Ctrl" + > 123: " Shift " + key + " selection"; > 124: throw new RuntimeException(failureMsg); Suggestion: A StringBuffer can be used to log the errors and the RuntimeException can be thrown at the end after checking both cases- left and right selection similar to this test https://github.com/openjdk/jdk/blob/47c8a6a8db979fe862be876008feb76cdc9dccfd/test/jdk/javax/swing/plaf/metal/MetalBorders/ScaledMetalBorderTest.java#L82 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20608#discussion_r1725977520
