On Tue, 20 Aug 2024 07:26:12 GMT, Tejesh R <t...@openjdk.org> wrote: >> In JTable, keyboard navigation keys Ctrl Shift RIGHT/LEFT doesn't follow >> native actions of Linux. In native the actions are extended to end of >> selected columns cells either LEFT/RIGHT but in swing gtk look and feel the >> selection is extended to one cell to left/right. This might be taken as >> reference of Windows OS since the same is observed in Windows native. Hence >> I have update the actions for Ctrl Shift RIGHT & LEFT. >> Added automated test too. The fix is tested in CI and its fine. > > Tejesh R has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains four additional commits since > the last revision: > > - Updated review comments > - Merge branch 'master' of https://git.openjdk.java.net/jdk into > branch_8338041 > - Test updates > - Key action modified + Automatic test added
src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java line 1062: > 1060: "shift KP_RIGHT", > "selectNextColumnExtendSelection", > 1061: "ctrl shift RIGHT", > "selectLastColumnExtendSelection", > 1062: "ctrl shift KP_RIGHT", > "selectNextColumnExtendSelection", should KP_RIGHT also be changed to selectLastColumnExtendSelection? Should keypad shortcuts be identical to the arrow key shortcuts? src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java line 1070: > 1068: "shift KP_LEFT", > "selectPreviousColumnExtendSelection", > 1069: "ctrl shift LEFT", > "selectFirstColumnExtendSelection", > 1070: "ctrl shift KP_LEFT", > "selectPreviousColumnExtendSelection", here as well ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20608#discussion_r1727876631 PR Review Comment: https://git.openjdk.org/jdk/pull/20608#discussion_r1727877541
