On Thu, 12 Dec 2024 04:32:14 GMT, SendaoYan <s...@openjdk.org> wrote:
> Hi all, > This PR fix file src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c > reported compile warning "ignoring return value of function" by clang17, > which add check the return value of `realpath` function. Risk is low. Drive-By comment: I think we should avoid `perror`, since its error message is localized. I would prefer these messages in English, not in whatever language the customer set up. If you really want to print a message, at least also print out the numerical value of errno. See https://pubs.opengroup.org/onlinepubs/007904875/functions/perror.html "The perror() function shall map the error number accessed through the symbol errno to a _language-dependent_ error message" ------------- PR Comment: https://git.openjdk.org/jdk/pull/22701#issuecomment-2550866548
