On Fri, 13 Dec 2024 08:26:05 GMT, SendaoYan <s...@openjdk.org> wrote:
>>> Should I combine 3 similar >>> issues([JDK-8346104](https://bugs.openjdk.org/browse/JDK-8346104)/[JDK-8346103](https://bugs.openjdk.org/browse/JDK-8346103)/[JDK-8346059](https://bugs.openjdk.org/browse/JDK-8346059)) >>> to 1 issue >> >> I personally would probably have started out by making a single issue for >> these, since they all try to address the same new warning in clang, and are >> all in client code, and only split it up later if reviewers had requested >> it. But since you have created separate issues, I suggest you do not change >> things now. Also, the other two I believe need a more serious response; a >> write to a pipe has a somewhat more realistic chance at failure than this >> filename lookup. > > Sorry for the confuse. I mean this PR change nothing except it will print a > message to stderr when realpath return NULL. Thanks magicus. Why did you integrate this ? It did not yet have my approval even though I was clearly reviewing it. Nor did it have the required 2nd reviewer, in fact did it not have ANY reviewer from the client team which is responsible for this code. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22701#discussion_r1888708459
