On Tue, 17 Dec 2024 15:27:30 GMT, Phil Race <p...@openjdk.org> wrote:
>> Sorry for the confuse. I mean this PR change nothing except it will print a >> message to stderr when realpath return NULL. Thanks magicus. > > Why did you integrate this ? > It did not yet have my approval even though I was clearly reviewing it. > Nor did it have the required 2nd reviewer, in fact did it not have ANY > reviewer from the client team which is responsible for this code. @prrace I don't think it is reasonable for you to blame @sendaoYan for integrating. He had a review from a Reviewer, and he waited 24 hours after that before integrating. The general JDK rule is that one review is enough; Hotspot as a special case requires two. Your comment did not say that you wanted to review it further, nor did you clearly request any changes, just a vague idea of replacing realpath with a strcpy (which seems like much more risky, and potentially incorrect, change!) The responsibility for this PR is mine. I had reviewed and approved the PR. I did consider if I should increase the number of reviewers and state that a client team reviewer was also needed, but decided against it. That was my decision as a reviewer. The PR was clearly unproblematic. It added some extra logging in case something gets terribly wrong. Without this fix, AWT would just break without any indication whatsoever if something did go wrong with realpath. With this fix, this unlikely problem will at least get some indication. I did not think this needed confirmation from the client team as well. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22701#discussion_r1889966811
