On Tue, 28 Jan 2025 17:47:56 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Several TrayIcon tests are trying to click on the system tray icon with >> Robot using XTest API. >> >> Basically we have the same kind of failures as before, e.g. >> [JDK-8280990](https://bugs.openjdk.org/browse/JDK-8280990) >>> the reason is this is using XTEST, an X11 protocol which will not work >>> outside of X11. >>> >>> In other words, the emulated input event reaches the X11 clients, but not >>> the Wayland compositor which is the actual display server but also the X11 >>> window manager in Wayland, the component which is in charge of >>> moving/resizing/stacking the windows. >> >> I also tested the same tests by clicking manually instead of using the >> robot, and it works as expected. >> So for now, skip those tests on Wayland (and do some minor cleanup). >> >> Testing after modifications is also green. > > test/jdk/java/awt/TrayIcon/ActionCommand/ActionCommand.java line 148: > >> 146: if (!actionPerformed) { >> 147: throw new RuntimeException("FAIL: ActionEvent not triggered >> when TrayIcon is "+(isMacOS? "" : "double ")+"clicked"); >> 148: } else if (! "Sample Command".equals(actionCommand)) { > > Suggestion: > > } else if (!"Sample Command".equals(actionCommand)) { Here, the chained `if` statements could be changed to separate statements. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23329#discussion_r1932620308
