On Tue, 28 Jan 2025 18:40:00 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
>> Several TrayIcon tests are trying to click on the system tray icon with >> Robot using XTest API. >> >> Basically we have the same kind of failures as before, e.g. >> [JDK-8280990](https://bugs.openjdk.org/browse/JDK-8280990) >>> the reason is this is using XTEST, an X11 protocol which will not work >>> outside of X11. >>> >>> In other words, the emulated input event reaches the X11 clients, but not >>> the Wayland compositor which is the actual display server but also the X11 >>> window manager in Wayland, the component which is in charge of >>> moving/resizing/stacking the windows. >> >> I also tested the same tests by clicking manually instead of using the >> robot, and it works as expected. >> So for now, skip those tests on Wayland (and do some minor cleanup). >> >> Testing after modifications is also green. > > Alexander Zvegintsev has updated the pull request incrementally with two > additional commits since the last revision: > > - minor > - review comments Marked as reviewed by aivanov (Reviewer). test/jdk/java/awt/TrayIcon/TrayIconPopup/TrayIconPopupClickTest.java line 79: > 77: "\"Always show all icons and notifications on the > taskbar\" true " + > 78: "to avoid this problem. Or change behavior only for > Java SE " + > 79: "tray icon."); These instructions are outdated, at the same time, they're visible only on the test log… *I'd rather leave them as is* — it's out of scope to amend the instructions to be accurate for Windows 10 and 11. ------------- PR Review: https://git.openjdk.org/jdk/pull/23329#pullrequestreview-2587845730 PR Review Comment: https://git.openjdk.org/jdk/pull/23329#discussion_r1937964332
