On Tue, 28 Jan 2025 18:40:00 GMT, Alexander Zvegintsev <azveg...@openjdk.org> 
wrote:

>> Several TrayIcon tests are trying to click on the system tray icon with 
>> Robot using XTest API.
>> 
>> Basically we have the same kind of failures as before, e.g. 
>> [JDK-8280990](https://bugs.openjdk.org/browse/JDK-8280990)
>>>  the reason is this is using XTEST, an X11 protocol which will not work 
>>> outside of X11.
>>>
>>> In other words, the emulated input event reaches the X11 clients, but not 
>>> the Wayland compositor which is the actual display server but also the X11 
>>> window manager in Wayland, the component which is in charge of 
>>> moving/resizing/stacking the windows. 
>> 
>> I also tested the same tests by clicking manually instead of using the 
>> robot, and it works as expected.
>> So for now, skip those tests on Wayland (and do some minor cleanup).
>> 
>> Testing after modifications is also green.
>
> Alexander Zvegintsev has updated the pull request incrementally with two 
> additional commits since the last revision:
> 
>  - minor
>  - review comments

I noticed the same issue when testing on Wayland for some tests regarding 
SystemTray/TrayIcon. One of the ones I looked at was actually 
TrayIconPopupTest, which you covered here. Makes sense to just skip them for 
now where possible.

-------------

Marked as reviewed by dnguyen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/23329#pullrequestreview-2587914491

Reply via email to