On Thu, 30 Jan 2025 07:41:33 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   formatting
>
> test/jdk/javax/swing/JMenuItem/TestImageIconWithJRadioButtonMenuItem.java 
> line 45:
> 
>> 43: public class TestImageIconWithJRadioButtonMenuItem {
>> 44: 
>> 45:     private static final String instructionsText = """
> 
> Suggestion:
> 
>     private static final String INSTRUCTIONSTEXT = """

For what it's worth, it should be `INSTRUCTIONS_TEXT` with the underscore 
separating words.

It's not required to capitalise private constants, only public constants use 
all capitals with underscores between words.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1940969316

Reply via email to