On Thu, 6 Mar 2025 18:59:23 GMT, Phil Race <p...@openjdk.org> wrote: > FWIW the current fix isn't what I'd like to see. > Putting a check for Windows L&F in a BasicUI class ?? We had a similar issue > with GTK some months ago and it was something that we managed to avoid. Isn't > there a Windows L&F sub-class we can do this in ??
Since the Windows L&F check in Basic*UI class is a bone of contention, I have removed it and put the code in Windows specific class although there's around 200+ lines of code duplication as most of the required helper methods in BasicMenuItemUI class has private access.. CI run in windows is ok.. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23324#issuecomment-2706975903
