On Thu, 13 Mar 2025 03:04:47 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> > > Can we move these helper methods into a utility class which has public > > > access to both `Basic*UI` and `Windows*UI`? `SwingUtilities3`, or a new > > > class? > > > > OK..Moved..PR updated > > Guess I have taken care of the problematic windows L&F check in Basic class > and reduced the code duplication.. Any more comments @aivanov-jdk? Thank you! I'm sorry, I've been unable to look at the changes thoroughly, and there are many changes now. I looked at [the screenshot](https://github.com/openjdk/jdk/pull/23324#pullrequestreview-2677986364) that @kumarabhi006 attached, I still think the text of the menu items that have no icon should move to right and align with menu items that have icons. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23324#issuecomment-2725497063
