On Mon, 10 Mar 2025 13:11:33 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> > > > FWIW the current fix isn't what I'd like to see. > > > > Putting a check for Windows L&F in a BasicUI class ?? We had a similar > > > > issue with GTK some months ago and it was something that we managed to > > > > avoid. Isn't there a Windows L&F sub-class we can do this in ?? > > > > > > > > > Since the Windows L&F check in Basic*UI class is a bone of contention, I > > > have removed it and put the code in Windows specific class although > > > there's around 200+ lines of code duplication as most of the required > > > helper methods in BasicMenuItemUI class has private access.. CI run in > > > windows is ok.. > > > > > > Can we move these helper methods into a utility class which has public > > access to both `Basic*UI` and `Windows*UI`? `SwingUtilities3`, or a new > > class? > > OK..Moved..PR updated Guess I have taken care of the problematic windows L&F check in Basic class and reduced the code duplication.. Any more comments @aivanov-jdk @prrace ? Wanted to get it in before test sprint if possible.. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23324#issuecomment-2719710156
