On Tue, 8 Apr 2025 22:24:47 GMT, Phil Race <p...@openjdk.org> wrote:
>> Open source 4 Swing JProgressBar tests.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8353483
LGTM apart from the minor inline comments
test/jdk/javax/swing/JProgressBar/bug4230391.java line 86:
> 84: JPanel panel = new JPanel();
> 85: panel.setLayout(new BoxLayout(panel,BoxLayout.X_AXIS));
> 86: JLabel label = new JLabel(name);
Unused variable
test/jdk/javax/swing/JProgressBar/bug4230391.java line 91:
> 89: UIManager.setLookAndFeel(plaf);
> 90:
> 91: ComponentOrientation rtl = ComponentOrientation.RIGHT_TO_LEFT;
Unused var
test/jdk/javax/swing/JProgressBar/bug4393042.java line 73:
> 71: if (frame != null) {
> 72: frame.dispose();
> 73: }
Line spacing needs to be adjusted.
test/jdk/javax/swing/JProgressBar/bug4393042.java line 87:
> 85: progressBar.setValue(0);
> 86: frame.add(progressBar);
> 87: frame.setSize(200, 100);
Increasing frame size will allow the frame title to be seen (especially since
it is an automated test).
test/jdk/javax/swing/JProgressBar/bug5003022.java line 26:
> 24: /*
> 25: * @test
> 26: * @bug 4785160
Is the bugID 5003022 ?
-------------
Marked as reviewed by honkar (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24517#pullrequestreview-2751616443
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2034169581
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2034169613
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2034171278
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2034174694
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2034175409
