On Wed, 9 Apr 2025 18:22:56 GMT, Phil Race <p...@openjdk.org> wrote:
>> Open source 4 Swing JProgressBar tests.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8353483
test/jdk/javax/swing/JProgressBar/RightLeftOrientation.java line 81:
> 79: static JPanel createBarSet(ComponentOrientation o) {
> 80: JPanel panel = new JPanel();
> 81: panel.setLayout(new BoxLayout(panel,BoxLayout.Y_AXIS));
Suggestion:
panel.setLayout(new BoxLayout(panel, BoxLayout.Y_AXIS));
test/jdk/javax/swing/JProgressBar/RightLeftOrientation.java line 104:
> 102: ComponentOrientation o) {
> 103: JPanel panel = new JPanel();
> 104: panel.setLayout(new BoxLayout(panel,BoxLayout.Y_AXIS));
Suggestion:
panel.setLayout(new BoxLayout(panel, BoxLayout.Y_AXIS));
test/jdk/javax/swing/JProgressBar/RightLeftOrientation.java line 132:
> 130:
> 131: UIManager.setLookAndFeel(save);
> 132: } catch(Exception e) {
Suggestion:
} catch (Exception e) {
test/jdk/javax/swing/JProgressBar/bug4230391.java line 71:
> 69: static JPanel createBarSet() {
> 70: JPanel panel = new JPanel();
> 71: panel.setLayout(new BoxLayout(panel,BoxLayout.Y_AXIS));
Suggestion:
panel.setLayout(new BoxLayout(panel, BoxLayout.Y_AXIS));
test/jdk/javax/swing/JProgressBar/bug4230391.java line 85:
> 83: static JPanel createProgressBars(String name, String plaf) {
> 84: JPanel panel = new JPanel();
> 85: panel.setLayout(new BoxLayout(panel,BoxLayout.X_AXIS));
Suggestion:
panel.setLayout(new BoxLayout(panel, BoxLayout.X_AXIS));
test/jdk/javax/swing/JProgressBar/bug4230391.java line 124:
> 122: JFrame frame = new JFrame("Progress Bar Insets Test");
> 123: Container contentPane = frame.getContentPane();
> 124: contentPane.setLayout(new
> BoxLayout(contentPane,BoxLayout.X_AXIS));
Suggestion:
contentPane.setLayout(new BoxLayout(contentPane, BoxLayout.X_AXIS));
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2040259369
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2040259501
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2040259688
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2040259930
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2040260146
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2040260255
