On Tue, 8 Apr 2025 23:36:33 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8353483
>
> test/jdk/javax/swing/JProgressBar/bug4230391.java line 86:
>
>> 84: JPanel panel = new JPanel();
>> 85: panel.setLayout(new BoxLayout(panel,BoxLayout.X_AXIS));
>> 86: JLabel label = new JLabel(name);
>
> Unused variable
fixed
> test/jdk/javax/swing/JProgressBar/bug4230391.java line 91:
>
>> 89: UIManager.setLookAndFeel(plaf);
>> 90:
>> 91: ComponentOrientation rtl =
>> ComponentOrientation.RIGHT_TO_LEFT;
>
> Unused var
fixed
> test/jdk/javax/swing/JProgressBar/bug4393042.java line 73:
>
>> 71: if (frame != null) {
>> 72: frame.dispose();
>> 73: }
>
> Line spacing needs to be adjusted.
fixed
> test/jdk/javax/swing/JProgressBar/bug4393042.java line 87:
>
>> 85: progressBar.setValue(0);
>> 86: frame.add(progressBar);
>> 87: frame.setSize(200, 100);
>
> Increasing frame size will allow the frame title to be seen (especially since
> it is an automated test).
fixed
> test/jdk/javax/swing/JProgressBar/bug5003022.java line 26:
>
>> 24: /*
>> 25: * @test
>> 26: * @bug 4785160
>
> Is the bugID 5003022 ?
fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2035894186
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2035894353
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2035894863
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2035894508
PR Review Comment: https://git.openjdk.org/jdk/pull/24517#discussion_r2035894686
