On Mon, 14 Apr 2025 21:52:02 GMT, Phil Race <p...@openjdk.org> wrote:
> Open source some more Swing menu tests test/jdk/javax/swing/JPopupMenu/bug4212464.java line 54: > 52: > 53: static String strMetal = "Metal"; > 54: static String metalClassName = > "javax.swing.plaf.metal.MetalLookAndFeel"; Extra space can be removed. test/jdk/javax/swing/JPopupMenu/bug4234793.java line 64: > 62: * 2. The mouse is clicked on another component. > 63: * > 64: * @test `@test` not required here test/jdk/javax/swing/JPopupMenu/bug4234793.java line 84: > 82: > 83: Notice each time you perform a hide/cancel action an appropriate > message should > 84: appear in the log area _"Click to display the menu, then to hide it, LEFT click on the window background."_ does not produce PopupMenu cancelled msg for the 2 menus on the menubar and the combobox menu. But clicking the mouse on another component does cause the popup cancelled msg to be displayed. test/jdk/javax/swing/JPopupMenu/bug4234793.java line 194: > 192: > 193: //message.setText(msg); > 194: //message.repaint(); Commented lines can be removed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2043230778 PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2043237791 PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2043237822 PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2043240833
