On Mon, 14 Apr 2025 21:52:02 GMT, Phil Race <p...@openjdk.org> wrote:
> Open source some more Swing menu tests
test/jdk/javax/swing/JPopupMenu/bug4234793.java line 178:
> 176: comboPanel.add(combo);
> 177:
> 178: //JLabel message = new JLabel("Message area");
Commented stmts can be removed.
test/jdk/javax/swing/JPopupMenu/bug4234793.java line 243:
> 241: public void popupMenuWillBecomeVisible(PopupMenuEvent e) {
> 242: Object source = e.getSource();
> 243: setMessage("popupmenu visible: " + source.getClass().getName());
Here and at other locations
Suggestion:
PassFailJFrame.log("popupmenu visible: " + source.getClass().getName());
test/jdk/javax/swing/JPopupMenu/bug4234793.java line 248:
> 246: public void popupMenuWillBecomeInvisible(PopupMenuEvent e) {
> 247: Object source = e.getSource();
> 248: System.out.println("popupMenuWillBecomeInvisible: " +
> source.getClass().getName());
Suggestion:
PassFailJFrame.log("popupMenuWillBecomeInvisible: " +
source.getClass().getName());
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2043251119
PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2043249646
PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2043250194
