On Mon, 14 Apr 2025 21:52:02 GMT, Phil Race <p...@openjdk.org> wrote:
> Open source some more Swing menu tests
test/jdk/javax/swing/JPopupMenu/bug4212464.java line 125:
> 123: public void actionPerformed(ActionEvent e) {
> 124: String str = e.getActionCommand();
> 125: if(str.equals(metalClassName) || str.equals(motifClassName)) {
Suggestion:
if (str.equals(metalClassName) || str.equals(motifClassName)) {
test/jdk/javax/swing/JPopupMenu/bug4234793.java line 125:
> 123: // CTRL-down will show the popup.
> 124: panel.getInputMap().put(KeyStroke.getKeyStroke(
> 125: KeyEvent.VK_DOWN,InputEvent.CTRL_MASK),"OPEN_POPUP");
Suggestion:
KeyEvent.VK_DOWN,InputEvent.CTRL_MASK), "OPEN_POPUP");
test/jdk/javax/swing/JPopupMenu/bug4234793.java line 158:
> 156: }
> 157:
> 158: static class PopupHandler extends AbstractAction{
Suggestion:
static class PopupHandler extends AbstractAction {
test/jdk/javax/swing/JPopupMenu/bug4234793.java line 159:
> 157:
> 158: static class PopupHandler extends AbstractAction{
> 159: public void actionPerformed(ActionEvent e){
Suggestion:
public void actionPerformed(ActionEvent e) {
test/jdk/javax/swing/JPopupMenu/bug4234793.java line 160:
> 158: static class PopupHandler extends AbstractAction{
> 159: public void actionPerformed(ActionEvent e){
> 160: if(!popupMenu.isVisible())
Suggestion:
if (!popupMenu.isVisible())
test/jdk/javax/swing/JPopupMenu/bug4234793.java line 207:
> 205:
> 206: menubar.add(menu);
> 207: for(int i = 0; i < 10; i ++) {
Suggestion:
for (int i = 0; i < 10; i ++) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2044277465
PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2044274534
PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2044275722
PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2044275500
PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2044275298
PR Review Comment: https://git.openjdk.org/jdk/pull/24636#discussion_r2044270452
