On Thu, 24 Apr 2025 15:20:08 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Anass Baya has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Put the frame in the centre of the screen.
>>
>> Co-authored-by: Alexey Ivanov <alexey.iva...@oracle.com>
>> - library regtesthelpers is no more used
>> - Alexey's proposed enhancement
>
> test/jdk/javax/swing/JComboBox/ComboPopupBug.java line 63:
>
>> 61: if (frame != null) {
>> 62: SwingUtilities.invokeAndWait(() -> frame.dispose());
>> 63: }
>
> The null-check should be on EDT too, all the tests follow this pattern.
> Suggestion:
>
> SwingUtilities.invokeAndWait(() -> {
> if (frame != null) {
> frame.dispose();
> }
> });
Thank you. I had doubt about it but i saw in a recent updated Test
Test6827032.java that it is not done on the EDT thread.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24624#discussion_r2058770367
