On Fri, 25 Apr 2025 18:59:35 GMT, Anass Baya <ab...@openjdk.org> wrote:
>> This test was designed to manually verify that clicking on the JComboBox >> when the frame containing it is about to close does not cause an >> IllegalStateException. >> >> The test allowed the tester extra time to click on the JComboBox when >> closing the frame by adding a Thread.sleep() in the close button handler. >> >> In this test, a JComboBox is displayed with a Close button at the bottom. >> The tester should click the Close button, then try to click the JComboBox >> arrow button to display the popup. >> >> In the automated test, we save the JComboBox location size before closing >> the frame. We then use this information to click on the JComboBox right >> before the frame is closed. > > Anass Baya has updated the pull request incrementally with one additional > commit since the last revision: > > Frame null-check before disposing the frame on the EDT Looks good to me. I think @prsadhuk, as the original author of the test, should also take a look. ------------- Marked as reviewed by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/24624#pullrequestreview-2795059760
