On Wed, 23 Apr 2025 21:05:06 GMT, Anass Baya <ab...@openjdk.org> wrote:
>> This test was designed to manually verify that clicking on the JComboBox >> when the frame containing it is about to close does not cause an >> IllegalStateException. >> >> The test allowed the tester extra time to click on the JComboBox when >> closing the frame by adding a Thread.sleep() in the close button handler. >> >> In this test, a JComboBox is displayed with a Close button at the bottom. >> The tester should click the Close button, then try to click the JComboBox >> arrow button to display the popup. >> >> In the automated test, we save the JComboBox location size before closing >> the frame. We then use this information to click on the JComboBox right >> before the frame is closed. > > Anass Baya has updated the pull request incrementally with three additional > commits since the last revision: > > - Adapt with JAVA code style > > Co-authored-by: Alexey Ivanov <alexey.iva...@oracle.com> > - Make clickComboBox private > > Co-authored-by: Alexey Ivanov <alexey.iva...@oracle.com> > - Reduce indentation. > > Co-authored-by: Alexey Ivanov <alexey.iva...@oracle.com> Please, never force-push to branches that are on review. This invalidates all the review comments which become orphaned because the commit is now gone. This also makes impossible to pull the changes locally: + b50ae1a7aa8...87292a19bf0 JDK-8354219 -> anass/JDK-8354219 (forced update) ... fatal: Not possible to fast-forward, aborting. There should never be a situation where force-push is necessary. Don't use `git rebase` after you published your branch for review. Use `git merge` to merge changes from master. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24624#issuecomment-2831107950
