On Wed, 14 May 2025 04:10:44 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8356049
>
> src/java.desktop/share/classes/javax/sound/SoundClip.java line 93:
> 
>> 91:      * Each time this method is called, the clip is restarted from the 
>> beginning.
>> 92:      */
>> 93:     public synchronized void play() {
> 
> We might want to clarify that play() and loop() are non-blocking in terms of 
> execution but may keep the application alive if audio threads are still 
> running.

And still do we want to have all of them synchronized? so the app may affect 
these methods by synchronized(soundClip)?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24991#discussion_r2088012769

Reply via email to