On Fri, 16 May 2025 21:03:18 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:

>> The API calls are best protected this way just like the ones in AudioClip 
>> were. There's no advantage in removing them. I don't think there's anything 
>> to document.
>
> Hmm I did not see all this responses for yesterday...

>The API calls are best protected this way just like the ones in AudioClip 
>were. There's no advantage in removing them.
But previously it was protected by methods in the non-public 
JavaSoundAudioClip, which extended AudioClip. Now SoundClip wraps 
JavaSoundAudioClip with the same results. Moreover, previously synchronized was 
not part of the public API, now it is.

One of the benefits to remove them is that it will not be possible to abuse 
synchronized(SoundClip) which will block execution of its methods.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24991#discussion_r2093678819

Reply via email to