On Wed, 14 May 2025 03:31:47 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8356049
>
> src/java.desktop/share/classes/com/sun/media/sound/JavaSoundAudioClip.java
> line 131:
>
>> 129: }
>> 130: } catch (UnsupportedAudioFileException e) {
>> 131: // not an audio file
>
> This code path seems will not be (rarely) executed?
> The midi file will be handled above by the AudioSystem.getAudioInputStream()
> via SoftMidiAudioFileReader provider? But if converted midi->sampled data
> cannot be played via audio device then it might be useful to try MidiDevice,
> but I do not think it can be done by catching UnsupportedAudioFileException.
Perhaps but that's the behaviour today and I don't see the need to change it in
order to provide a different API to reach here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24991#discussion_r2093505994
