On Thu, 26 Jun 2025 12:24:10 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> MenuItem with icon fix > > src/java.desktop/share/classes/com/sun/java/swing/SwingUtilities3.java line > 77: > >> 75: private static Color disabledForeground; >> 76: private static Color acceleratorSelectionForeground; >> 77: private static Color acceleratorForeground; > > Why are these static? I'm pretty sure the colors can be menu item specific, > although more commonly they would be L&F specific. Why is this comment marked resolved but not resolved at all? You store a local state of a MenuItemUI in a global class — this cannot be right! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r2266450506
