On Mon, 11 Aug 2025 11:41:52 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> src/java.desktop/share/classes/com/sun/java/swing/SwingUtilities3.java line >> 77: >> >>> 75: private static Color disabledForeground; >>> 76: private static Color acceleratorSelectionForeground; >>> 77: private static Color acceleratorForeground; >> >> Why are these static? I'm pretty sure the colors can be menu item specific, >> although more commonly they would be L&F specific. > > Why is this comment marked resolved but not resolved at all? > > You store a local state of a MenuItemUI in a global class — this cannot be > right! I've submitted [JDK-8365389](https://bugs.openjdk.org/browse/JDK-8365389): *Remove static color fields from SwingUtilities3 and WindowsMenuItemUI* to address all the unresolved comments during this code review. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r2269964765
