On Mon, 11 Aug 2025 15:51:34 GMT, Phil Race <p...@openjdk.org> wrote:
>> Again this doesn't look right to me and this hasn't been resolved at all. >> These static variables are present in the class. > > This is odd. But since the painting is single-threaded, it shouldn't matter. > But this should be re-done. > Maybe I think it can wait for another day but it made me spot a bug. I believe there's a potential bug in `WindowsMenuItemUI.java` in the newly overridden method and new static fields. There's a chance that the colors aren't updated when needed. Yet I haven't come up with a test. > Maybe I think it can wait for another day but it made me spot a bug. Yeah, it can wait… This was integrated so quickly that I didn't have any chance to look at the latest code updates. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r2267362205