On Fri, 24 Oct 2025 05:45:23 GMT, Prasanta Sadhukhan <[email protected]> 
wrote:

>> Sergey Nazarkin has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Get rid of eudc.reg
>
> test/jdk/java/awt/8368882/FallbackFontNPE.java line 25:
> 
>> 23:  */
>> 24: 
>> 25: import java.awt.FontMetrics ;
> 
> space before ;

Fixed

> test/jdk/java/awt/8368882/FallbackFontNPE.java line 31:
> 
>> 29: public class FallbackFontNPE {
>> 30:     public static void main(String[] args) throws Exception {
>> 31:         BufferedImage bi = new BufferedImage(1,1,1);
> 
> give space in between params

Fixed

> test/jdk/java/awt/8368882/FallbackFontNPE.sh line 96:
> 
>> 94: 
>> 95: exit 0
>> 96: 
> 
> I am getting this in our CI run although test passed
> 
> 
> ----------System.out:(12/291)*----------
> Setup EUDC.tte font
> ...Write HKCU\\EUDC\\1252 record
> The operation completed successfully.
> 
> ...Copy custom EUDC.tte file
> Setup fallback font
> Run java test FallbackFontNPE
> Delete fallback font
> Restore registry record
> The operation completed successfully.
> 
> ...Delete test EUDC.tte
> ----------System.err:(3/228)----------
> ERROR: The system was unable to find the specified registry key or value.
> cp: cannot create regular file 'C:/WINDOWS/Fonts/EUDC.tte': Permission denied
> rm: cannot remove 'C:/WINDOWS/Fonts/EUDC.tte': No such file or directory

I was afraid of this, and I don't know how to fix it.  Without this file, the 
test never fails and becomes meaningless.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27551#discussion_r2459579699
PR Review Comment: https://git.openjdk.org/jdk/pull/27551#discussion_r2459579274
PR Review Comment: https://git.openjdk.org/jdk/pull/27551#discussion_r2459549056

Reply via email to