On Wed, 3 Dec 2025 21:45:56 GMT, Damon Nguyen <[email protected]> wrote:

>> There was a prior PR that attempted to fix this issue, but it was found that 
>> [JDK-8280987](https://bugs.openjdk.org/browse/JDK-8280987) was the more 
>> reasonable cause. The issue was caused by Ubuntu instances having a large 
>> amount of graphics configurations, hence a large amount of concurrent frames 
>> being open and tested on at a time. As such, the newly suggested fix was to 
>> instead break apart the test into batches.
>> 
>> This change creates and disposes of the test frames in batches of 20, up to 
>> the number of GC's identified. The original problem was recreated when 
>> testing on Ubuntu 24.04, and I have re-tested this with the updated test on 
>> the same device, and it passes. When debugging, 140 GC's were identified and 
>> all 140 frames were created and disposed of. Also tested this on macOS 15 
>> and the test also passes. CI looks good as well.
>
> Damon Nguyen has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Fix curly brace issue when moving code

test/jdk/java/awt/Frame/FrameVisualTest.java line 95:

> 93:                     });
> 94:                     Rectangle rect = new Rectangle(p, d);
> 95:                     BufferedImage img = robot.createScreenCapture(rect);

https://github.com/openjdk/jdk/pull/26871#discussion_r2298835087 is still valid 
for the updated test.

On Ubuntu, a batch of windows opens in one place, so only the top window in the 
stack is checked.

<img width="157" height="144" alt="Image" 
src="https://github.com/user-attachments/assets/769e72e3-70f5-4cd3-970d-1385724b6b92";
 />

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28646#discussion_r2598129828

Reply via email to