On Fri, 12 Dec 2025 18:06:05 GMT, Phil Race <[email protected]> wrote:
>> Is 33 seconds unreasonable for the test? I figured since the upper-limit of >> frame tests is set to 30, this 33 seconds would be the longest the test >> would run for. Also, the test only has 1 gc for other OS's so only 1 frame >> is tested for that. This avoids the shadow issue as well as creates a more >> stable test. > > I will take stability at the cost of some extra time. > Is 33 seconds unreasonable for the test? I figured since the upper-limit of > frame tests is set to 30, this 33 seconds would be the longest the test would > run for. Also, the test only has 1 gc for other OS's so only 1 frame is > tested for that. In CI it may be even slower, and we can achieve the same results in a third of the time with showing several windows at once. This can cumulatively save a lot of CI time over many runs. We can still apply the same upper limit to the frame count of frame tests, and this may make it even faster. > This avoids the shadow issue as well as creates a more stable test. This can be mitigated simply by adding spacing between the frames. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28646#discussion_r2619095403
