On Thu, 11 Dec 2025 21:33:35 GMT, Phil Race <[email protected]> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Space out batches of frames
>
> test/jdk/java/awt/Frame/FrameVisualTest.java line 67:
>
>> 65: System.out.println("frames.length: " + frames.length);
>> 66:
>> 67: // Iterate through gcs in batches of 20
>
> maybe we could have a var for this ? Perhaps even allow it to be set as a
> program arg even if you default to 20.
> Also wouldn't one at a time be the most stable ?
> Finally, is it even necessary to test ALL of them ? Isn't it sufficient to
> test 30-40 and call it a day ?
Good point. I have switched to a single frame at a time and have created a new
final var to limit the number of frames to test (30). When testing, the balance
of stability and testing duration felt reasonable. The test still creates,
tests, and disposes multiple frames on Ubuntu, and the test still passes
testing after the changes.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28646#discussion_r2612385452
