On Wed, 28 Jan 2026 04:45:19 GMT, Tejesh R <[email protected]> wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8376423 > > Test with same name > [Test6657026.java](https://github.com/openjdk/jdk/pull/29437/changes#diff-d392211a6f8e0b0b65dbf68abd45ca2ddf89e6bd787be1cd1ed20d0c33eb9644) > referring to same bug ID 6657026 exist in other places too, should we remove > those test too ? > Example : same file name referring to same bugid exists in path > "open/test/jdk/javax/swing/ToolTipManager/ ", > "open/test/jdk/javax/swing/plaf/metal/MetalBorders/ ", etc.,
> @TejeshR13, you're right, there are other tests which reference JDK-6657026: > > ``` > test/jdk/javax/swing/plaf/metal/MetalSliderUI/Test6657026.java > test/jdk/javax/swing/plaf/metal/MetalInternalFrameUI/Test6657026.java > test/jdk/javax/swing/plaf/metal/MetalBorders/Test6657026.java > test/jdk/javax/swing/plaf/metal/MetalBumps/Test6657026.java > test/jdk/javax/swing/plaf/basic/BasicSplitPaneUI/Test6657026.java > test/jdk/javax/swing/ToolTipManager/Test6657026.java > test/jdk/javax/swing/UIManager/Test6657026.java > ``` > > I looked at a few at the top. They test that the data are bound to > `AppContext`. Yet none of these tests fails for me, even with the changes > from this PR. > > Still, these tests should be removed sooner… or later. A couple of these are on my short-term radar. > @TejeshR13, you're right, there are other tests which reference JDK-6657026: > > ``` > test/jdk/javax/swing/plaf/metal/MetalSliderUI/Test6657026.java > test/jdk/javax/swing/plaf/metal/MetalInternalFrameUI/Test6657026.java > test/jdk/javax/swing/plaf/metal/MetalBorders/Test6657026.java > test/jdk/javax/swing/plaf/metal/MetalBumps/Test6657026.java > test/jdk/javax/swing/plaf/basic/BasicSplitPaneUI/Test6657026.java > test/jdk/javax/swing/ToolTipManager/Test6657026.java > test/jdk/javax/swing/UIManager/Test6657026.java > ``` > > I looked at a few at the top. They test that the data are bound to > `AppContext`. Yet none of these tests fails for me, even with the changes > from this PR. > > Still, these tests should be removed sooner… or later. test/jdk/javax/swing/UIManager/Test6657026.java is removed as part of this PR because it does fail. as you say, the others do not fail although MetalBumps fails for me in a different (metal) fix I'm working on. So I'm not sure they are testing what they should be. I expect I'll remove all the metal tests in the Metal fix that'll be coming shortly. The tooltip one is not one I'd noticed at all, but in general rather than just removing all app context tests up front, I'm trying (as much as I can) to remove them only when they fail, so I can relate it closely to a specific place where AppContext is removed. So I'll not remove those additional tests here, but soon enough they'll go. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29437#issuecomment-3814135901
