java.beans.beancontext.BeanContextSupport has add() and remove() methods which 
synchronize on their arguments.

1) This won't work with value types such as Integer, Byte, Short, etc ..
2) It seems unnecessary. The sychronization is already wrapped in       
 synchronized(BeanContext.globalHierarchyLock) {
..
}

The diff looks big but that's because it has to ex-dent a bunch of lines. It is 
really just a 4 line change.

-------------

Commit messages:
 - 8378999
 - 8378999

Changes: https://git.openjdk.org/jdk/pull/30008/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=30008&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8378999
  Stats: 97 lines in 1 file changed: 29 ins; 33 del; 35 mod
  Patch: https://git.openjdk.org/jdk/pull/30008.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/30008/head:pull/30008

PR: https://git.openjdk.org/jdk/pull/30008

Reply via email to