> java.beans.beancontext.BeanContextSupport has add() and remove() methods 
> which synchronize on their arguments.
> 
> 1) This won't work with value types such as Integer, Byte, Short, etc ..
> 2) It seems unnecessary. The sychronization is already wrapped in       
>  synchronized(BeanContext.globalHierarchyLock) {
> ..
> }
> 
> The diff looks big but that's because it has to ex-dent a bunch of lines. It 
> is really just a 4 line change.

Phil Race has updated the pull request incrementally with one additional commit 
since the last revision:

  8378999

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/30008/files
  - new: https://git.openjdk.org/jdk/pull/30008/files/ce757aea..8eeef05e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=30008&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=30008&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/30008.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/30008/head:pull/30008

PR: https://git.openjdk.org/jdk/pull/30008

Reply via email to