On Tue, 3 Mar 2026 17:35:26 GMT, Phil Race <[email protected]> wrote:

>> java.beans.beancontext.BeanContextSupport has add() and remove() methods 
>> which synchronize on their arguments.
>> 
>> 1) This won't work with value types such as Integer, Byte, Short, etc ..
>> 2) It seems unnecessary. The sychronization is already wrapped in       
>>  synchronized(BeanContext.globalHierarchyLock) {
>> ..
>> }
>> 
>> The diff looks big but that's because it has to ex-dent a bunch of lines. It 
>> is really just a 4 line change.
>
> Phil Race has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8378999

Marked as reviewed by aivanov (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/30008#pullrequestreview-3884644584

Reply via email to