On Mon, 23 Mar 2026 13:20:18 GMT, Alexey Ivanov <[email protected]> wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Included suggestions
>
> test/jdk/javax/swing/RepaintManager/RemoveInvalidComponentTest.java line 71:
>
>> 69: JLabel label2 = new EqualLabel("label");
>> 70:
>> 71: System.out.println(label1.equals(label2));
>
> I wonder whether it's better to enforce `label1.equals(label2)` returns
> `true` and fail the test otherwise:
>
>
> Suggestion:
>
> if (!label1.equals(label2)) {
> throw new RuntimeException("label1.equals(label2) returned
> false");
> }
Although this check is not our primary objective, it may become relevant in a
future revision.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30184#discussion_r2978778825
