On Tue, 24 Mar 2026 17:14:55 GMT, Sergey Bylokhov <[email protected]> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with 
>> one additional commit since the last revision:
>> 
>>   Added exception for .equal check
>>   
>>   Co-authored-by: Alexey Ivanov <[email protected]>
>
> test/jdk/javax/swing/RepaintManager/RemoveInvalidComponentTest.java line 76:
> 
>> 74: 
>> 75:         JFrame frame = new JFrame("RemoveInvalidComponentTest");
>> 76:         frame.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE);
> 
> This line is not needed?

Unless you comment out `frame.dispose()` to view how the frame looks. 
Otherwise, the frame will not close and the test will never exit.

It's common for tests to provide a default close operation, `DISPOSE_ON_CLOSE` 
is the safest option.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30184#discussion_r2983152057

Reply via email to