On Tue, 24 Mar 2026 21:35:07 GMT, Sergey Bylokhov <[email protected]> wrote:

>> Unless you comment out `frame.dispose()` to view how the frame looks. 
>> Otherwise, the frame will not close and the test will never exit.
>> 
>> It's common for tests to provide a default close operation, 
>> `DISPOSE_ON_CLOSE` is the safest option.
>
> It looks like most of the DISPOSE_ON_CLOSE usages in tests were added 
> recently. It is better not to use it since in some cases it allows bypassing 
> the test logic and make the test green. I also recall that at some point 
> several tests were cleaned up to remove it.

Thanks @mrserb for your suggestion, I have removed this line

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30184#discussion_r2985539218

Reply via email to