On Fri, 7 Aug 2026 02:30:36 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> Aqua classes for text components enables dragEnabled by default although >> setDragEnabled spec cites `"The default value of the dragEnabled property is >> false. "` and there is nothing in Aqua L&F that mentions otherwise as to why >> the default is overridden. >> Other L&F dont override the mode and the code is there from macosx port days >> so it seems to be an oversight. >> >> The code is deleted. >> Test is added to check >> - default value is honoured in all installed L&Fs >> - explicit application setting of drag mode is preserved on L&F change >> >> CI testing is ok. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Review comment src/java.desktop/macosx/classes/com/apple/laf/AquaEditorPaneUI.java line 53: > 51: @Override > 52: protected void uninstallDefaults(){ > 53: if(!GraphicsEnvironment.isHeadless()){ Why default value is not restored? is it correct to assume that custom L&F will not be affected by this change if L&F will be changed from Aqua to custom L&F? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32101#discussion_r3738412814
