On Fri, 7 Aug 2026 02:30:36 GMT, Prasanta Sadhukhan <[email protected]> 
wrote:

>> Aqua classes for text components enables dragEnabled by default although 
>> setDragEnabled spec cites `"The default value of the dragEnabled property is 
>> false. "` and there is nothing in Aqua L&F that mentions otherwise as to why 
>> the default is overridden.
>> Other L&F dont override the mode and the code is there from macosx port days 
>> so it seems to be an oversight.
>> 
>> The code is deleted.
>> Test is added to check 
>>  - default value is honoured in all installed L&Fs
>>  - explicit application setting of drag mode is preserved on L&F change
>> 
>>  CI testing is ok.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Prasanta Sadhukhan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Review comment

Changes requested by serb (Reviewer).

test/jdk/javax/swing/text/JTextComponent/TextComponentDragEnabledTest.java line 
42:

> 40: import javax.swing.SwingUtilities;
> 41: import javax.swing.UIManager;
> 42: import javax.swing.UnsupportedLookAndFeelException;

UnsupportedLookAndFeelException is unused?

-------------

PR Review: https://git.openjdk.org/jdk/pull/32101#pullrequestreview-4886190210
PR Review Comment: https://git.openjdk.org/jdk/pull/32101#discussion_r3738445543

Reply via email to