On Tue, 20 Oct 2026 21:45:14 GMT, Phil Race <[email protected]> wrote:
> The native code on macOS which initializes cached JNI refs is not thread safe. > The fix is to use the macOS dispatch_once mechanism as a lock. > The fix is essentially all in JNIUtilities.h. There's some refactoring of the > macros in there to make things a bit cleaner > and DECLARE_*_ONLY macros are added which the non-local clients now use to > declare variables. > > The problem can be demonstrated with multi-threaded initialisation, and using > -Xcheck:jni > A case which reproduces "fairly often" has been added as a test. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). src/java.desktop/macosx/native/libosxapp/JNIUtilities.h line 155: > 153: #define DECLARE_FIELD(dst_var, cls, name, signature) \ > 154: DECLARE_FIELD_ONLY(dst_var); \ > 155: GET_FIELD_ONLY(dst_var, cls, name, signature); DECLARE_FIELD use to do CHECK_NULL earlier!! It seems it will allow the enclosing function to continue with a null field ID and potentially a pending exception, maybe we need to restore the call to GET_FIELD to preserve the previous early-return behavior ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33481#discussion_r4441228137
