On Tue, 3 Nov 2026 19:37:03 GMT, Phil Race <[email protected]> wrote: >> src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m line 49: >> >>> 47: DECLARE_CLASS_ONLY(sjc_CPrinterDialog) >>> 48: DECLARE_CLASS_ONLY(sjm_getNSPrintInfo) >>> 49: DECLARE_CLASS_ONLY(sjm_printerJob) >> >> Should it be DECLARE_CLASS_ONLY for sjm_getNSPrintInfo and sjm_printerJob? >> Shouldn't it be DECLARE_METHOD_ONLY(sjm_getNSPrintInfo) and >> DECLARE_METHOD_ONLY(sjm_printerJob)? > > yes, fixed.
On 2nd look, it seems sjm_printerJob uses https://github.com/prrace/jdk/blob/0c360c3a027c61dc3c72eea839fa5c5ca95508a3/src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m#L64 so shouldn't it be DECLARE_FIELD_ONLY(sjm_printerJob) as sjm_printerJob is populated through GET_FIELD_RETURN(..., "fPrinterJob", ...) and passed to GetObjectField, so it needs jfieldID I presume!! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33481#discussion_r4490363081
