On Mon, 2 Nov 2026 10:16:45 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8393035 > > src/java.desktop/macosx/native/libawt_lwawt/awt/CPrinterJob.m line 49: > >> 47: DECLARE_CLASS_ONLY(sjc_CPrinterDialog) >> 48: DECLARE_CLASS_ONLY(sjm_getNSPrintInfo) >> 49: DECLARE_CLASS_ONLY(sjm_printerJob) > > Should it be DECLARE_CLASS_ONLY for sjm_getNSPrintInfo and sjm_printerJob? > Shouldn't it be DECLARE_METHOD_ONLY(sjm_getNSPrintInfo) and > DECLARE_METHOD_ONLY(sjm_printerJob)? yes, fixed. > src/java.desktop/macosx/native/libosxapp/JNIUtilities.h line 155: > >> 153: #define DECLARE_FIELD(dst_var, cls, name, signature) \ >> 154: DECLARE_FIELD_ONLY(dst_var); \ >> 155: GET_FIELD_ONLY(dst_var, cls, name, signature); > > DECLARE_FIELD use to do CHECK_NULL earlier!! > It seems it will allow the enclosing function to continue with a null field > ID and potentially a pending exception, maybe we need to restore the call to > GET_FIELD to preserve the previous early-return behavior yes, this is a typo. It should be GET_FIELD, analogous to the DECLARE_CLASS and DECLARE_METHOD cases. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33481#discussion_r4459558540 PR Review Comment: https://git.openjdk.org/jdk/pull/33481#discussion_r4459612343
