Also besides review metrics, is there any way to log and track defects (within 
Review Board) during code review like  CodeCollaborator. 

-----Original Message-----
From: David Nalley [mailto:da...@gnsa.us] 
Sent: Monday, July 09, 2012 7:12 PM
To: cloudstack-dev@incubator.apache.org
Subject: Re: ReviewBoard

On Mon, Jul 9, 2012 at 8:05 PM, Kevin Kluge <kevin.kl...@citrix.com> wrote:
> I'm surprised by the number of Pending and Submitted.  I have seen so many 
> approval messages (I counted 48 in my quick mailbox search) that it seems odd 
> that only 5 patches are classified as submitted.  Are people just not 
> completing the workflow when something gets submitted?
>
> -kevin
>

So I have found that if I use the exact phrase and author in the commit it will 
close it for me.
Otherwise, it will look like it is just hanging out there forever.
There is supposed to be an option to close - but it doesn't appear in the UI 
(and doesn't appear to have the options shown in the manual - so I suspect 
there is a perms issue). So in short, yes a workflow issue.

--David

Reply via email to