Are we agreed this is the workflow -- original submitter should check and then close as Submitted after the checkin?
We should also have the committers " use the exact phrase and author in the commit" as David says. This seems preferable as is effectively automated. -kevin > -----Original Message----- > From: Olga Smola [mailto:olya.sm...@gmail.com] > Sent: Wednesday, July 11, 2012 8:21 AM > To: cloudstack-dev@incubator.apache.org > Subject: Re: ReviewBoard > > David, > > thank you. Ok, every ticket should be checked if it really was committed. > > Olga > > On Wed, Jul 11, 2012 at 6:14 PM, David Nalley <da...@gnsa.us> wrote: > > > On Wed, Jul 11, 2012 at 11:08 AM, Olga Smola <olya.sm...@gmail.com> > wrote: > > > So if request gets "Ship it!", it should be submitted (choose the > > reviewed > > > ticket and from the menu "Close"/"Submitted"), am I right? > > > > > > Olga > > > > Correct - though I'd confirm that there is actually a corresponding > > commit that is actually made. There have been a number that have had > > 'ship it' in the review that didn't actually get committed til several > > days later. > > > > --David > >
