I think opnly the orginal submitter can close the request by selecting submitted or discarded. Indeed a workflow issue, I tend to close a request when it is applied by a committer, maybe it's nice to remind folks that they can close the request after it is applied. Maybe somebody can get permissions to also close requests by asking Infra team?
Hugo -----Original Message----- From: David Nalley [mailto:da...@gnsa.us] Sent: Tuesday, July 10, 2012 4:12 AM To: cloudstack-dev@incubator.apache.org Subject: Re: ReviewBoard On Mon, Jul 9, 2012 at 8:05 PM, Kevin Kluge <kevin.kl...@citrix.com> wrote: > I'm surprised by the number of Pending and Submitted. I have seen so many > approval messages (I counted 48 in my quick mailbox search) that it seems odd > that only 5 patches are classified as submitted. Are people just not > completing the workflow when something gets submitted? > > -kevin > So I have found that if I use the exact phrase and author in the commit it will close it for me. Otherwise, it will look like it is just hanging out there forever. There is supposed to be an option to close - but it doesn't appear in the UI (and doesn't appear to have the options shown in the manual - so I suspect there is a perms issue). So in short, yes a workflow issue. --David
