Vijay Please post the patch for community review and post the link in response to this thread
Animesh > -----Original Message----- > From: Chip Childers [mailto:chip.child...@sungard.com] > Sent: Tuesday, January 15, 2013 5:30 PM > To: <cloudstack-dev@incubator.apache.org> > Subject: Re: [IP Clearance: CLOUDSTACK-778] Feedback requested > > Can we see the patch in question? > > - chip > > On Jan 15, 2013, at 7:14 PM, Animesh Chaturvedi > <animesh.chaturv...@citrix.com> wrote: > > > In that case it looks like a simple contribution and in my opinion may not > > need > to go through IP clearance process. Folks if you have objection to this > assessment please call out. > > > > Thanks > > Animesh > > > >> -----Original Message----- > >> From: Vijayendra Bhamidipati > >> [mailto:vijayendra.bhamidip...@citrix.com] > >> Sent: Tuesday, January 15, 2013 3:45 PM > >> To: cloudstack-dev@incubator.apache.org > >> Subject: RE: [IP Clearance: CLOUDSTACK-778] Feedback requested > >> > >> Hi Animesh, > >> > >> The feature has changes amounting to about 150 lines of code. It was > >> intended specifically for vCenter deployments that would allow users > >> to append guest VM instance names to the internal names shown on the > >> hypervisor (i.e., in vCenter), if a global flag vm.instancename.flag > >> is turned on, during guest VM creation. The feature however works on > >> all hypervisors and has been coded that way, but it doesn't impinge > >> on any existing CS functionality and should be easy to merge into > >> ACS. The only part that may need to be done differently is in the > >> upgrade scripts from the previous ACS version to the current one, and that > would only involve putting in a new global flag. > >> > >> Regards, > >> Vijay > >> > >> > >> -----Original Message----- > >> From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] > >> Sent: Tuesday, January 15, 2013 2:24 PM > >> To: cloudstack-dev@incubator.apache.org > >> Subject: [IP Clearance: CLOUDSTACK-778] Feedback requested > >> > >> Vijay > >> > >> This issue was flagged for potential IP clearance issue. Please > >> provide some more details on this issue and approximate effort in LOC > >> needed to address this issue. Community needs to determine the > >> contribution effort and then call out whether it needs to go through IP > clearance. > >> > >> > >> Thanks > >> Animesh > >> > >>> Chip Childers reopened CLOUDSTACK-778: > >>> -------------------------------------- > >>> > >>> > >>> Reopening, since we (1) don't have the code in the repo and (2) need > >>> to sort out the ip ownership questions on this feature before > >>> inclusion. Please feel free to submit to reviewboard, but note that > >>> we should NOT commit until ip clearance is complete. > >