My mistake for interrupting in the thread. --Alex
> -----Original Message----- > From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] > Sent: Tuesday, January 15, 2013 5:24 PM > To: cloudstack-dev@incubator.apache.org > Subject: RE: [IP Clearance: CLOUDSTACK-778] Feedback requested > > So this really looks like two different issues. Vijay please create a separate > [DISCUSS] thread for 715. Let's keep this thread only for community > feedback on 778 > > > -----Original Message----- > > From: Vijayendra Bhamidipati [mailto:vijayendra.bhamidip...@citrix.com] > > Sent: Tuesday, January 15, 2013 5:13 PM > > To: cloudstack-dev@incubator.apache.org > > Subject: RE: [IP Clearance: CLOUDSTACK-778] Feedback requested > > > > Hi Alex! > > > > Actually the changes for this instance name feature were all in the > > management layers and not in the resource layer and apply to all > hypervisors, > > so we would not be able to tie this change to overall vmware support > > specifically in 4.1. > > > > Regarding 715, during the previous discussion that Kelven, yourself and I > had, > > Kelven had mentioned that we currently use the closed source client > libraries > > released by vmware, which as he pointed out in his comments in 715, have > > changed a lot in vSphere 5.1 and infact break compile time compatibility > with > > cloudstack. The same compile time compatibility breakage was seen with > the > > open source 5.1 API also since it moves alongside the closed source version. > > > > To sum up the discussion we had, we would need to have both the closed > > source vim25.jar file (for backward compatibility) and the newer vim25.jar > > (that comes with vSphere 5.1) to work with newer vCenter features going > > forward. This latter jar file we could either generate ourselves from the > wsdl > > files or possibly use the open source version of vi sdk's vim25.jar if the > license > > allows it. Either ways, we would need to modify existing cloudstack code > for > > vmware to separate it on the lines of how we do it for XAPI so that it uses > the > > right API calls depending on the version of vmware. This would be more > > involved so it wouldn't be doable very quickly. Some cleanup with other jar > files > > like apputils.jar could also be required. > > > > > > Regards, > > Vijay > > > > > > -----Original Message----- > > From: Alex Huang [mailto:alex.hu...@citrix.com] > > Sent: Tuesday, January 15, 2013 4:32 PM > > To: cloudstack-dev@incubator.apache.org > > Subject: RE: [IP Clearance: CLOUDSTACK-778] Feedback requested > > > > Hey Vijay, > > > > I just realized that this fix might mean we can finally make vmware support > > part of oss. Can you evaluate this against the following issue? > > > > https://issues.apache.org/jira/browse/CLOUDSTACK-715 > > > > Is it something you can do very quickly for 4.1? Kelven says there's still > some > > helper classes we have to replace to make it completely free of vmware > > licensed code. > > > > Thanks. > > > > --Alex > > > > > -----Original Message----- > > > From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] > > > Sent: Tuesday, January 15, 2013 4:14 PM > > > To: cloudstack-dev@incubator.apache.org > > > Subject: RE: [IP Clearance: CLOUDSTACK-778] Feedback requested > > > > > > In that case it looks like a simple contribution and in my opinion may > > > not need to go through IP clearance process. Folks if you have > > > objection to this assessment please call out. > > > > > > Thanks > > > Animesh > > > > > > > -----Original Message----- > > > > From: Vijayendra Bhamidipati > > > > [mailto:vijayendra.bhamidip...@citrix.com] > > > > Sent: Tuesday, January 15, 2013 3:45 PM > > > > To: cloudstack-dev@incubator.apache.org > > > > Subject: RE: [IP Clearance: CLOUDSTACK-778] Feedback requested > > > > > > > > Hi Animesh, > > > > > > > > The feature has changes amounting to about 150 lines of code. It was > > > intended > > > > specifically for vCenter deployments that would allow users to > > > > append > > > guest > > > > VM instance names to the internal names shown on the hypervisor > > > > (i.e., in vCenter), if a global flag vm.instancename.flag is turned > > > > on, during guest > > > VM > > > > creation. The feature however works on all hypervisors and has been > > > coded > > > > that way, but it doesn't impinge on any existing CS functionality > > > > and should > > > be > > > > easy to merge into ACS. The only part that may need to be done > > > > differently > > > is in > > > > the upgrade scripts from the previous ACS version to the current > > > > one, and > > > that > > > > would only involve putting in a new global flag. > > > > > > > > Regards, > > > > Vijay > > > > > > > > > > > > -----Original Message----- > > > > From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] > > > > Sent: Tuesday, January 15, 2013 2:24 PM > > > > To: cloudstack-dev@incubator.apache.org > > > > Subject: [IP Clearance: CLOUDSTACK-778] Feedback requested > > > > > > > > Vijay > > > > > > > > This issue was flagged for potential IP clearance issue. Please > > > > provide some more details on this issue and approximate effort in > > > > LOC needed to address > > > this > > > > issue. Community needs to determine the contribution effort and > > > > then call > > > out > > > > whether it needs to go through IP clearance. > > > > > > > > > > > > Thanks > > > > Animesh > > > > > > > > > Chip Childers reopened CLOUDSTACK-778: > > > > > -------------------------------------- > > > > > > > > > > > > > > > Reopening, since we (1) don't have the code in the repo and (2) > > > > > need to sort out the ip ownership questions on this feature before > > > > > inclusion. Please feel free to submit to reviewboard, but note > > > > > that we should NOT commit until ip clearance is complete. > > > > >
